mkdocs-website/docs/en/changelog.md (1)

35-35: Documentation improvement needed for critical behavior change.

While the changelog entry correctly describes the new behavior, this significant change to application lifecycle management would benefit from additional documentation:

1. Consider adding examples of the shutdown sequence
2. Document any timeout mechanisms during shutdown
3. Clarify the order of service shutdown

Consider expanding the changelog entry to:

- service.OnStartup now shutdowns the application on error and runs service.OnShutdown for any prior services that started by @atterpac in [#3920](https://github.com/wailsapp/wails/pull/3920)
+ service.OnStartup now implements graceful shutdown on initialization errors:
+   - Automatically terminates the application when a service fails to start
+   - Ensures proper cleanup by calling OnShutdown() on all previously started services
+   - Services are shut down in reverse order of their startup
+   by @atterpac in [#3920](https://github.com/wailsapp/wails/pull/3920)

v3/pkg/application/application.go (2)

147-147: Clarify log message for better readability

The log message might be confusing due to missing punctuation. Adding a comma after "failed" improves clarity.

Proposed change:

- globalApplication.Logger.Error("OnStartup() failed shutting down application:", "service", name, "error", err.Error())
+ globalApplication.Logger.Error("OnStartup() failed, shutting down application:", "service", name, "error", err.Error())

---

149-149: Avoid variable shadowing in nested loops for improved code clarity

The inner loop variable service shadows the outer loop variable service, which can lead to confusion. Renaming the inner loop variable enhances readability.

Proposed change:

- for _, service := appOptions.Services[:i] {
+ for _, startedService := appOptions.Services[:i] {

Configuration used: .coderabbit.yaml
Review profile: CHILL

mkdocs-website/docs/en/changelog.md (2)

35-35: Consider expanding the changelog entry with more details.

While the current entry correctly describes the change, consider adding more details about:

• The specific error scenarios that trigger application shutdown
• The order of operations during shutdown
• Any potential migration steps for existing applications

Here's a suggested expansion:

- `service.OnStartup` now shutdowns the application on error and runs `service.OnShutdown`for any prior services that started by @atterpac in [#3920](https://github.com/wailsapp/wails/pull/3920)
+ `service.OnStartup` now handles errors more gracefully by:
+   - Shutting down the application when a service fails to start
+   - Running `service.OnShutdown` in reverse order for any previously started services
+   - Ensuring proper cleanup of resources before application exit
+   by @atterpac in [#3920](https://github.com/wailsapp/wails/pull/3920)

---

35-35: Fix typo in changelog entry.

There's a missing space between OnShutdown and for.

- `service.OnStartup` now shutdowns the application on error and runs `service.OnShutdown`for any prior services that started by @atterpac in [#3920](https://github.com/wailsapp/wails/pull/3920)
+ `service.OnStartup` now shutdowns the application on error and runs `service.OnShutdown` for any prior services that started by @atterpac in [#3920](https://github.com/wailsapp/wails/pull/3920)

v3/pkg/application/application.go (1)

147-147: Enhance error logging message

The error message could be more descriptive to help with debugging. Consider including additional context about the startup sequence.

-globalApplication.Logger.Error("OnStartup() failed shutting down application:", "service", name, "error", err.Error())
+globalApplication.Logger.Error("Application startup failed - initiating shutdown sequence", "failed_service", name, "error", err.Error(), "startup_sequence", i+1)

Configuration used: .coderabbit.yaml
Review profile: CHILL

v3/pkg/application/application.go (1)

147-147: Enhance error logging with structured fields

The error logging could be improved by using structured logging fields consistently.

-globalApplication.Logger.Error("OnStartup() failed shutting down application:", "service", name, "error", err.Error())
+globalApplication.Logger.Error("OnStartup() failed, shutting down application", 
+    "service", name,
+    "error", err,
+    "phase", "startup")

Configuration used: .coderabbit.yaml
Review profile: CHILL

-// Shutdown the application
-runtime.Goexit()
+// Cleanup and shutdown the application
+if a.cleanup != nil {
+  a.cleanup()
+}
+a.cancel() // Cancel the context to signal shutdown
+runtime.Goexit() // Keep as last resort if cleanup fails

-for _, service := range appOptions.Services[:i] {
-  if thisService, ok := service.instance.(ServiceShutdown); ok {
-    err := thisService.OnShutdown()
-    if err != nil {
-      globalApplication.Logger.Error("Error shutting down service: " + err.Error())
-    }
-  }
-}
+shutdownErrors := []error{}
+for _, service := range appOptions.Services[:i] {
+  if thisService, ok := service.instance.(ServiceShutdown); ok {
+    if err := thisService.OnShutdown(); err != nil {
+      shutdownErrors = append(shutdownErrors, fmt.Errorf("failed to shutdown service %s: %w", 
+        service.options.Name, err))
+    }
+  }
+}
+if len(shutdownErrors) > 0 {
+  globalApplication.Logger.Error("errors occurred during shutdown sequence", 
+    "errors", shutdownErrors,
+    "phase", "cleanup")
+}

#!/bin/bash
# Description: Find all service implementations to verify error handling
# Look for service implementations that might need updating

# Find all files implementing ServiceStartup
echo "Searching for ServiceStartup implementations..."
ast-grep --pattern 'type $service struct {
  $$$
}

func ($x *$service) OnStartup($ctx context.Context, $opts any) error {
  $$$
}'

# Find all files implementing ServiceShutdown
echo "Searching for ServiceShutdown implementations..."
ast-grep --pattern 'type $service struct {
  $$$
}

func ($x *$service) OnShutdown() error {
  $$$
}'

#!/bin/bash
# Search for interface implementations using ripgrep
echo "Searching for ServiceStartup interface implementations..."
rg "OnStartup\(.*context\.Context.*\)" -B 5 -A 10

echo -e "\nSearching for ServiceShutdown interface implementations..."
rg "OnShutdown\(\).*error" -B 5 -A 10